Re: [PATCH v4 06/10] kern/ieee1275/cmain: ppc64: Introduce flags to identify Power VM and KVM

[Michael Ellerman]

Stefan Berger <stefanb@linux.ibm.com> writes:
> Introduce flags to identify PowerVM and PowerKVM and set them where
> each type of host has been detected.

Minor nit, "PowerKVM" was the name of a productised version of KVM on
Power, but it was discontinued many years ago.

The thing that exists these days is just "KVM" running on Power.

cheers

> diff --git a/grub-core/kern/ieee1275/cmain.c b/grub-core/kern/ieee1275/cmain.c
> index 400d85d28..cc7c32873 100644
> --- a/grub-core/kern/ieee1275/cmain.c
> +++ b/grub-core/kern/ieee1275/cmain.c
> @@ -126,7 +126,10 @@ grub_ieee1275_find_options (void)
>  
>  #if defined(__powerpc__)
>        if (grub_strncmp (tmp, "IBM,", 4) == 0)
> -     grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_CAN_TRY_CAS_FOR_MORE_MEMORY);
> +     {
> +       grub_ieee1275_set_flag 
> (GRUB_IEEE1275_FLAG_CAN_TRY_CAS_FOR_MORE_MEMORY);
> +       grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_POWER_VM);
> +     }
>  #endif
>      }
>  
> @@ -193,6 +196,7 @@ grub_ieee1275_find_options (void)
>        grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_NO_PRE1_5M_CLAIM);
>  
>        grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_HAS_CURSORONOFF);
> +      grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_POWER_KVM);
>      }
>  }
>  
> diff --git a/include/grub/ieee1275/ieee1275.h 
> b/include/grub/ieee1275/ieee1275.h
> index 9f669fbee..5b7a36ad8 100644
> --- a/include/grub/ieee1275/ieee1275.h
> +++ b/include/grub/ieee1275/ieee1275.h
> @@ -140,6 +140,10 @@ enum grub_ieee1275_flag
>     * only 256MB in size, try asking for more with CAS.
>     */
>    GRUB_IEEE1275_FLAG_CAN_TRY_CAS_FOR_MORE_MEMORY,
> +
> +  GRUB_IEEE1275_FLAG_POWER_VM,
> +
> +  GRUB_IEEE1275_FLAG_POWER_KVM,
>  #endif
>  };
>  
> -- 
> 2.25.1