[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] acpi: Mark MADT entries as packed.
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] acpi: Mark MADT entries as packed. |
|
Date: |
Mon, 6 Nov 2023 18:04:10 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Oct 31, 2023 at 08:20:14PM +0100, Vladimir 'phcoder' Serbinenko wrote:
> From 9d03ab04df3b723058fb0b7c30576e1330cbad5d Mon Sep 17 00:00:00 2001
> From: Vladimir Serbinenko <phcoder@gmail.com>
> Date: Tue, 31 Oct 2023 18:27:19 +0100
> Subject: [PATCH] acpi: Mark MADT entries as packed.
>
> No alignment is guaranteed and in fact on my ia64 sapic is aligned
> to 4 bytes instead of 8 and causes a trap. It affects only rarely used
> lsacpi command and so went unnoticed.
At least you missed grub_acpi_madt_entry_header struct. It should have
packed attribute too.
Daniel
- Re: [PATCH] acpi: Mark MADT entries as packed.,
Daniel Kiper <=