[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/util/grub-shell: Enable RNG device to better test stac
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] tests/util/grub-shell: Enable RNG device to better test stack smashing |
|
Date: |
Sat, 2 Sep 2023 20:28:16 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Aug 31, 2023 at 11:50:56PM -0500, Glenn Washburn wrote:
> In certain firmwares, eg. OVMF, the RNG protocol is not enabled unless
> there is an RNG device. When not enabled, GRUB fails to initialize the
> stack guard with random bytes. For testing, this is not a big issue, but
> there have been bugs found in the initialization. So turn this on for EFI
> platforms to catch any regressions.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> ---
> This patch will potentially cause a lot of failures on EFI platforms
> because of a bug in stack smashing initialization, which the list has
> been notified of. This patch is in part meant to exercise that bug and
> allows successful test runs when that bug is fixed.
I will review the patch mentioned above and then push both patches
together to not break tests at this point.
Daniel