Re: [PATCH v5 2/8] Unify GUID types

[Daniel Kiper]

On Thu, Mar 30, 2023 at 01:18:07PM +0200, Oliver Steffen wrote:
> There are 3 implementations of a GUID in Grub. Replace them with a
> common one, placed in types.h.
>
> It uses the "packed" flavor of the GUID structs, the alignment attribute
> is dropped, since it is not required.
>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

But one nit below...

> diff --git a/grub-core/commands/acpi.c b/grub-core/commands/acpi.c
> index fda62f4ea..fb2fe8325 100644
> --- a/grub-core/commands/acpi.c
> +++ b/grub-core/commands/acpi.c
> @@ -759,8 +759,8 @@ grub_cmd_acpi (struct grub_extcmd_context *ctxt, int 
> argc, char **args)
>
>  #ifdef GRUB_MACHINE_EFI
>    {
> -    struct grub_efi_guid acpi = GRUB_EFI_ACPI_TABLE_GUID;
> -    struct grub_efi_guid acpi20 = GRUB_EFI_ACPI_20_TABLE_GUID;
> +    grub_guid_t acpi = GRUB_EFI_ACPI_TABLE_GUID;
> +    grub_guid_t acpi20 = GRUB_EFI_ACPI_20_TABLE_GUID;

I would add static for these two variables.

Daniel