Re: [PATCH] ieee1275/ofdisk: retry on open and read failure

[Robbie Harwood]

Michael Chang via Grub-devel <grub-devel@gnu.org> writes:

> On Tue, Mar 28, 2023 at 11:00:01AM +0530, Mukesh Kumar Chaurasiya wrote:
>> Sometimes, when booting from a very busy SAN, the access to the
>> disk can fail and then grub will eventually drop to grub prompt.
>> This scenario is more frequent when deploying many machines at
>> the same time using the same SAN.
>> This patch aims to force the ofdisk module to retry the open or
>> read function after it fails. We use MAX_RETRIES to specify the
>> amount of times it will try to access the disk before it
>> definitely fails.
>
> To clarify this is a continuation of previous patch [1]. Obviously the
> count of retries, MAX_RETRIES, has been replaced by a timeout,
> RETRY_DEFAULT_TIMEOUT, which is 15000 milliseconds or fifteen seconds.
> It appears that the description was not updated accordingly and needs to
> be amended.
>
> [1] https://www.mail-archive.com/grub-devel@gnu.org/msg32174.html

We carry that ^ patch basically as-is downstream.  This proposed patch
seems rather different: there's environment logic, more functions, etc..
As Michael says, it would be helpful if what's happening here could be
clarified - especially since the description mentions MAX_RETRIES from
Diego's patch, but there's no mention of Diego's authorship in the
commit message, and no MAX_RETRIES in the code...

Be well,
--Robbie

signature.asc
Description: PGP signature