[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] Fix command line underflows and out-of-bounds write
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH 0/2] Fix command line underflows and out-of-bounds write |
|
Date: |
Tue, 29 Nov 2022 14:52:48 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Sat, Nov 26, 2022 at 05:22:50PM -0500, Ryan Cohen wrote:
> Hello everyone,
>
> I was messing around in the GRUB command line and I found two related
> integer underflows that occur on all platforms. I also found an
> out-of-bounds write that occurs only on i386 systems using the VGA text
> terminal. This out-of-bounds write is caused by one of the underflows,
> but I've included 2 patches so that each bug is fixed.
>
> This is my first patch submission for GRUB, so please let me know if
> there is anything I should change or fix. I really appreciate feedback!
>
> Thanks to Daniel Kiper for helping me figure out the process of
> submitting a patch. :)
>
> Ryan Cohen (2):
> vga_text: Prevent out-of-bounds writes to VGA text buffer
> cmdline: Fix two related integer underflows
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com> for both patches...
Thank you for finding and fixing these issues!
Daniel