[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH V2 3/9] fs/minix: Fix memory leak in grub_minix_lookup_symlink
From: |
t . feng |
Subject: |
[PATCH V2 3/9] fs/minix: Fix memory leak in grub_minix_lookup_symlink |
Date: |
Tue, 29 Nov 2022 17:14:09 +0800 |
Fix memory leaks in grub_minix_lookup_symlink.
Fixes: a07e6ad01(Remove variable length arrays)
Signed-off-by: "t.feng" <fengtao40@huawei.com>
---
grub-core/fs/minix.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/grub-core/fs/minix.c b/grub-core/fs/minix.c
index 953df1191..5354951d1 100644
--- a/grub-core/fs/minix.c
+++ b/grub-core/fs/minix.c
@@ -374,7 +374,7 @@ grub_minix_lookup_symlink (struct grub_minix_data *data,
grub_minix_ino_t ino)
if (!symlink)
return grub_errno;
if (grub_minix_read_file (data, 0, 0, 0, sz, symlink) < 0)
- return grub_errno;
+ goto fail;
symlink[sz] = '\0';
@@ -384,10 +384,12 @@ grub_minix_lookup_symlink (struct grub_minix_data *data,
grub_minix_ino_t ino)
/* Now load in the old inode. */
if (grub_minix_read_inode (data, ino))
- return grub_errno;
+ goto fail;
grub_minix_find_file (data, symlink);
+ fail:
+ grub_free(symlink);
return grub_errno;
}
--
2.27.0
- [PATCH V2 0/9] fix memory leaks in fs module, t . feng, 2022/11/29
- [PATCH V2 3/9] fs/minix: Fix memory leak in grub_minix_lookup_symlink,
t . feng <=
- [PATCH V2 7/9] fs/iso9660: Fix memory leak in grub_iso9660_susp_iterate, t . feng, 2022/11/29
- [PATCH V2 2/9] fs/btrfs: Fix memory leak in find_path, t . feng, 2022/11/29
- [PATCH V2 8/9] fs/squash4: Fix memeory leak in grub_squash_iterate_dir, t . feng, 2022/11/29
- [PATCH V2 6/9] fs/hfsplus: Fix memory leak in grub_hfsplus_btree_search, t . feng, 2022/11/29
- [PATCH V2 9/9] fs/xfs: Fix memory leaks in xfs, t . feng, 2022/11/29
- [PATCH V2 5/9] fs/bfs: Fix memory leak in read_bfs_file, t . feng, 2022/11/29
- [PATCH V2 1/9] fs/affs:Fix memory leaks in grub_affs_create_node, t . feng, 2022/11/29
- [PATCH V2 4/9] fs/ntfs: Fix memory leak in grub_ntfs_read_symlink, t . feng, 2022/11/29
- Re: [PATCH V2 0/9] fix memory leaks in fs module, Daniel Kiper, 2022/11/29