Re: [PATCH 4/9] fs/ntfs: Fix memory leak in grub_ntfs_read_symlink

[Daniel Kiper]

On Sat, Nov 19, 2022 at 06:39:41PM +0800, t.feng via Grub-devel wrote:
> Fix memory leaks in grub_ntfs_read_symlink.
>
> Fixes: 5773fb641(Support NTFS reparse points.)
>
> Signed-off-by: "t.feng" <fengtao40@huawei.com>
> ---
>  grub-core/fs/ntfs.c | 26 ++++++++++++++++++++++----
>  1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/grub-core/fs/ntfs.c b/grub-core/fs/ntfs.c
> index 3511e4e2c..eb5170ab7 100644
> --- a/grub-core/fs/ntfs.c
> +++ b/grub-core/fs/ntfs.c
> @@ -667,20 +667,27 @@ grub_ntfs_read_symlink (grub_fshelp_node_t node)
>      return NULL;
>
>    if (read_mft (mft->data, mft->buf, mft->ino))
> -    return NULL;
> +    {
> +      grub_free (mft->buf);
> +      return NULL;
> +    }

I would use "goto fail" construct in this patch too...

Daniel