grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] term/serial: Add support for PCI serial devices


From: Glenn Washburn
Subject: Re: [PATCH] term/serial: Add support for PCI serial devices
Date: Thu, 25 Aug 2022 20:01:39 -0500

On Thu, 25 Aug 2022 21:33:31 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> On Thu, Aug 25, 2022 at 10:51:29AM -0500, Glenn Washburn wrote:
> > On Thu, 25 Aug 2022 09:57:32 +0200
> > Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > On Wed, Aug 24, 2022 at 06:36:27PM -0500, Glenn Washburn wrote:
> > > > You will need to run the bootstrap script in the root of the repo to
> > > > rebuild the build scripts before running configure and make.
> > > 
> > > FWIW bootstrap scribbles INSTALL
> > 
> > Its been a while since I've looked at this. But I believe that INSTALL
> > is copied to INSTALL.grub. Is INSTALL getting overwritten with a
> > default INSTALL not related to GRUB? I'm unsure of what you're really
> > wanting to convey here. Something actionable?
> 
> When you do ./bootstrap; git diff returns a fairly sizable diff on
> INSTALL, which is a bit weird and tends to sneak into patches (had to
> kill it twice etc..).
> 
> So either add INSTALL to .gitignore, or fix it so that INSTALL doesn't
> get scribbled would be my suggestion.

Strange, I don't see that behavior. Maybe its your autotools version.

Glenn



reply via email to

[Prev in Thread] Current Thread [Next in Thread]