grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 1/2] misc: Add cast in grub_strncasecmp() to drop sign whe


From: Daniel Kiper
Subject: Re: [PATCH v5 1/2] misc: Add cast in grub_strncasecmp() to drop sign when calling grub_tolower()
Date: Fri, 19 Aug 2022 18:51:43 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Thu, Aug 11, 2022 at 12:48:42PM -0500, Glenn Washburn wrote:
> Note this cast was fixed in grub_strcasecmp() in commit ce41ab7aab
> (* grub-core/kern/misc.c (grub_strcmp): Use unsigned comparison as per
> common usage and preffered in several parts of code.), but this commit
> omitted fixing it in grub_strncasecmp().
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]