Re: [PATCH] configure.ac: warn if stack-protector not allowed

[Mike Gilbert]

On Fri, Jun 24, 2022 at 2:12 PM Nicholas Vinson <nvinson234@gmail.com> wrote:
>
> On 6/24/22 12:28, Daniel Kiper wrote:
> > Adding Chris...
> >
> > On Tue, Jun 14, 2022 at 06:19:00PM -0400, Nicholas Vinson wrote:
> >> Previous version of configure.ac would error out when
> >> --enable-stack-protector was given and a selected GRUB platform did not
> >> support the flag.  The new behavior is to warn that the flag is not
> >> supported and force disable it for that platform.
> >
> > Could you explain why do we need this change? I think it is safer to
> > fail in this case than warn.
>
> What happened is I tried to modify Gentoo's GRUB ebuild so it would
> unconditionally pass --enable-stack-protector to configure. However, the
> ebuild also has a GRUB_PLATFORMS variable which allows it to build for
> multiple GRUB platforms simultaneously for. For me the value of that
> variable is set to "pc efi-64". Therefore, when I tried to install GRUB
> the build would fail because the GRUB "pc" platform does not support
> --enable-stack-protector.

If desired, I could add a USE flag and associated logic to the Gentoo
ebuild to support this. Please file a bug at https://bugs.gentoo.org/
if that is something you would like to see.