[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] tests: Show host determined fs UUID when hfs UUID test f
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH 1/4] tests: Show host determined fs UUID when hfs UUID test fails |
|
Date: |
Fri, 27 May 2022 16:16:48 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, May 11, 2022 at 10:19:44PM -0500, Glenn Washburn wrote:
> On failure, the hfs test should show both the host and GRUB determined fs
> UUID. Prior to this change, both outputs where generated by GRUB, which is
> less helpful in determining the cause of failure.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
> tests/util/grub-fs-tester.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in
> index 3c1d712de..d323665d2 100644
> --- a/tests/util/grub-fs-tester.in
> +++ b/tests/util/grub-fs-tester.in
> @@ -1353,7 +1353,7 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE"
> "$MAXLOGSECSIZE" 1); do
> :
> else
> echo UUID FAIL
> - echo "$LSOUT"
> + echo "$FSUUID"
I am not sure why you drop 'echo "$LSOUT"' here.
Otherwise patches LGTM.
Daniel