[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version
|
From: |
Robbie Harwood |
|
Subject: |
Re: [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions |
|
Date: |
Thu, 26 May 2022 17:07:11 -0400 |
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> writes:
> There are no users left of version_find_latest(), version_test_gt(), and
> version_test_numeric(). Remove those unused helper functions. Using
> those helper functions is what caused the quadratic sorting performance
> issues in the first place, so removing them is a net win.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Reviewed-by: Robbie Harwood <rharwood@redhat.com>
Be well,
--Robbie
signature.asc
Description: PGP signature
- [RFC PATCH v3 0/5] grub-mkconfig: Fix quadratic algorithm for sorting menu items, Mathieu Desnoyers, 2022/05/20
- [RFC PATCH v3 2/5] grub-mkconfig linux_xen: Fix quadratic algorithm for sorting menu items, Mathieu Desnoyers, 2022/05/20
- [RFC PATCH v3 4/5] grub-mkconfig kfreebsd: Fix quadratic algorithm for sorting menu items, Mathieu Desnoyers, 2022/05/20
- [RFC PATCH v3 1/5] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items, Mathieu Desnoyers, 2022/05/20
- [RFC PATCH v3 3/5] grub-mkconfig hurd: Fix quadratic algorithm for sorting menu items, Mathieu Desnoyers, 2022/05/20
- [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions, Mathieu Desnoyers, 2022/05/20
- Re: [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions,
Robbie Harwood <=
Re: [RFC PATCH v3 0/5] grub-mkconfig: Fix quadratic algorithm for sorting menu items, Mathieu Desnoyers, 2022/05/20