Re: [PATCH v2 4/5] cryptodisk: Use enum constants as indexes into cryptomount option array

[Daniel Kiper]

On Fri, May 13, 2022 at 12:00:50PM -0500, Glenn Washburn wrote:
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>  grub-core/disk/cryptodisk.c | 53 ++++++++++++++++++++++---------------
>  1 file changed, 32 insertions(+), 21 deletions(-)
>
> diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c
> index 94640b502..ecbda7ce9 100644
> --- a/grub-core/disk/cryptodisk.c
> +++ b/grub-core/disk/cryptodisk.c
> @@ -35,6 +35,17 @@ GRUB_MOD_LICENSE ("GPLv3+");
>
>  grub_cryptodisk_dev_t grub_cryptodisk_list;
>
> +enum
> +  {
> +    OPTION_UUID,
> +    OPTION_ALL,
> +    OPTION_BOOT,
> +    OPTION_PASSWORD,
> +    OPTION_KEYFILE,
> +    OPTION_KEYFILE_OFFSET,
> +    OPTION_KEYFILE_SIZE
> +  };

I would prefer constants here.

Otherwise patches LGTM.

Daniel