grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] configure: Fix default -O2 being added when CFLAGS not se


From: Robbie Harwood
Subject: Re: [PATCH v3] configure: Fix default -O2 being added when CFLAGS not set
Date: Mon, 11 Apr 2022 12:49:01 -0400

Glenn Washburn <development@efficientek.com> writes:

> Autoconf will set a default CFLAGS of "-g -O2" if CFLAGS is not set. CFLAGS
> was defaulted to "" early in configure to prevent this. A recent commit
> ad9ccf660013c208077b1e983d6c824df25ed1cf ("configure: Fix various new
> autotools warnings") added AC_USE_SYSTEM_EXTENSIONS, which pulls in the
> autoconf CFLAGS check, before we default CFLAGS and thus setting the
> autoconf default for CFLAGS. Move the default setting of CFLAGS to before
> AC_USE_SYSTEM_EXTENSIONS so that autoconf will see CFLAGS as set and not
> give it a default.
>
> CFLAGS is also moved above AC_CONFIG_AUX_DIR, because CFLAGS should be
> defaulted to "" as soon as possible to catch any autoconf macros that try
> to use some other default. Regardless, this currently has no effect as that
> macro does not consider the CFLAGS variable.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Robbie Harwood <rharwood@redhat.com>

Be well,
--Robbie

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]