[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 09/15] efi: mm: Pass up errors from `add_memory_regions ()

From: Daniel Kiper
Subject: Re: [PATCH v2 09/15] efi: mm: Pass up errors from `add_memory_regions ()`
Date: Thu, 7 Apr 2022 16:15:08 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Mon, Mar 28, 2022 at 05:22:34PM +1100, Daniel Axtens wrote:
> From: Patrick Steinhardt <>
> The function `add_memory_regions ()` is currently only called on system
> initialization to allocate a fixed amount of pages. As such, it didn't
> need to return any errors: in case it failed, we cannot proceed anyway.
> This will change with the upcoming support for requesting more memory
> from the firmware at runtime, where it doesn't make sense anymore to
> fail hard.
> Refactor the function to return an error to prepare for this. Note that
> this does not change the behaviour when initializing the memory system
> because `grub_efi_mm_init ()` knows to call `grub_fatal ()` in case
> `grub_efi_mm_add_regions ()` returns an error.
> Signed-off-by: Patrick Steinhardt <>
> [dja: clarify error messages]
> Signed-off-by: Daniel Axtens <>

Reviewed-by: Daniel Kiper <>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]