[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] configure: Fix default -O2 being added when CFLAGS not set

From: Glenn Washburn
Subject: Re: [PATCH] configure: Fix default -O2 being added when CFLAGS not set
Date: Mon, 28 Mar 2022 10:53:01 -0500

On Fri, 25 Mar 2022 11:54:59 -0400
Robbie Harwood <> wrote:

> Glenn Washburn <> writes:
> > Autoconf will set a default CFLAGS of "-g -O2" if CFLAGS is not set. CFLAGS
> > was defaulted to "" early in configure to prevent this. Apparently something
> > changed in autoconf and now AC_USE_SYSTEM_EXTENSIONS, which is before the
> > default setting of CFLAGS, will pull in this check. Move the default
> > setting of CFLAGS to before this so that if will see CFLAGS as set and not
> > give it a default.
> This is a result of ad9ccf660013c208077b1e983d6c824df25ed1cf
> ("configure: Fix various new autotools warnings"), which hoisted
> AC_USE_SYSTEM_EXTENSIONS to avoid a new warning (slightly too far, it
> seems).

I neglected to check the commit log, which hints at the fact that this
isn't an issue in autoconf. Thanks for pointing this out, I'll update
the commit message with this info to more accurately reflect what's
going on.


> > Signed-off-by: Glenn Washburn <>
> Reviewed-by: Robbie Harwood <>
> Be well,
> --Robbie

reply via email to

[Prev in Thread] Current Thread [Next in Thread]