Re: [PATCH 1/2] EFI: console: Do not set colorstate until the first text output

[Daniel Kiper]

On Fri, Mar 04, 2022 at 11:30:13AM +0100, Hans de Goede wrote:
> Hi Daniel,
>
> On 1/28/22 12:43, Hans de Goede wrote:
> > GRUB_MOD_INIT(normal) does an unconditional:
> >
> > grub_env_set ("color_normal", "light-gray/black");
> >
> > which triggers a grub_term_setcolorstate() call. The original version
> > of the "efi/console: Do not set text-mode until we actually need it" patch:
> > https://lists.gnu.org/archive/html/grub-devel/2018-03/msg00125.html
> >
> > Protected against this by caching the requested state in
> > grub_console_setcolorstate () and then only applying it when the first
> > text output actually happens. During refactoring to move the
> > grub_console_setcolorstate () up higher in the grub-core/term/efi/console.c
> > file the code to cache the color-state + bail early was accidentally
> > dropped.
> >
> > Restore the cache the color-state + bail early behavior from the original.
> >
> > Cc: Javier Martinez Canillas <javierm@redhat.com>
> > Fixes: 2d7c3abd871f ("efi/console: Do not set text-mode until we actually 
> > need it")
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> What is the status of this series? It has been well over a month and both
> patches have received 2 Reviewed-by-s and no other comments:
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> Reviewed-by: Robbie Harwood <rharwood@redhat.com>

Argh... By mistake I forgot to add Javier's and Robbie's RB. Sorry about that...

Daniel