[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/7] grub-core/loader/i386/pc/linux.c: Fix uninitialized scala
From: |
Alec Brown |
Subject: |
[PATCH v2 2/7] grub-core/loader/i386/pc/linux.c: Fix uninitialized scalar variable |
Date: |
Mon, 21 Mar 2022 02:28:57 -0400 |
In the function grub_linux16_boot(), struct grub_relocator16_state state is
called but isn't being initialized. This results in the members grub_uint32_t
ebx, grub_uint32_t edx, grub_uint32_t esi, and grub_uint32_t ebp being filled
with junk data from the stack since none of them are being set to any values. We
can prevent this by setting state to {0}.
Fixes: CID 375028
Signed-off-by: Alec Brown <alec.r.brown@oracle.com>
---
grub-core/loader/i386/pc/linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/loader/i386/pc/linux.c b/grub-core/loader/i386/pc/linux.c
index 2a2995201..bf4dc0488 100644
--- a/grub-core/loader/i386/pc/linux.c
+++ b/grub-core/loader/i386/pc/linux.c
@@ -55,7 +55,7 @@ static grub_err_t
grub_linux16_boot (void)
{
grub_uint16_t segment;
- struct grub_relocator16_state state;
+ struct grub_relocator16_state state = {0};
segment = grub_linux_real_target >> 4;
state.gs = state.fs = state.es = state.ds = state.ss = segment;
--
2.27.0
- [PATCH v2 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Alec Brown, 2022/03/21
- [PATCH v2 4/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 1/7] grub-core/loader/i386/bsd.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 3/7] grub-core/net/arp.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 6/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 5/7] grub-core/net/net.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 7/7] grub-core/net/bootp.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/21
- [PATCH v2 2/7] grub-core/loader/i386/pc/linux.c: Fix uninitialized scalar variable,
Alec Brown <=
- Re: [PATCH v2 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Darren Kenny, 2022/03/21