[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 7/7] grub-core/net/bootp.c: Fix uninitialized scalar variable
From: |
Alec Brown |
Subject: |
[PATCH 7/7] grub-core/net/bootp.c: Fix uninitialized scalar variable |
Date: |
Tue, 15 Mar 2022 16:24:09 -0400 |
In the function grub_net_configure_by_dhcp_ack(),
grub_net_network_level_address_t addr is called but isn't being initialized. To
prevent contents of this structure from being filled with junk data from the
stack, we can initialize it to 0 by setting addr to {}.
Fixes: CID 375036
Signed-off-by: Alec Brown <alec.r.brown@oracle.com>
---
grub-core/net/bootp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/net/bootp.c b/grub-core/net/bootp.c
index 6fb562702..708d601df 100644
--- a/grub-core/net/bootp.c
+++ b/grub-core/net/bootp.c
@@ -232,7 +232,7 @@ grub_net_configure_by_dhcp_ack (const char *name,
grub_size_t size,
int is_def, char **device, char **path)
{
- grub_net_network_level_address_t addr;
+ grub_net_network_level_address_t addr = {};
grub_net_link_level_address_t hwaddr;
struct grub_net_network_level_interface *inter;
int mask = -1;
--
2.27.0
- [PATCH 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Alec Brown, 2022/03/15
- [PATCH 3/7] grub-core/net/arp.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 2/7] grub-core/loader/i386/pc/linux.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 7/7] grub-core/net/bootp.c: Fix uninitialized scalar variable,
Alec Brown <=
- [PATCH 1/7] grub-core/loader/i386/bsd.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 4/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 5/7] grub-core/net/net.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 6/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- Re: [PATCH 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Darren Kenny, 2022/03/15