[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/7] grub-core/net/arp.c: Fix uninitialized scalar variable
From: |
Alec Brown |
Subject: |
[PATCH 3/7] grub-core/net/arp.c: Fix uninitialized scalar variable |
Date: |
Tue, 15 Mar 2022 16:24:05 -0400 |
In the function grub_net_arp_receive(), grub_net_network_level_address_t
sender_addr and target_addr are being called but aren't being initialized. To
prevent contents of these structures from being filled with junk data from the
stack, we can initialize them to 0 by setting sender_addr and target_addr to {}.
Fixes: CID 375030
Signed-off-by: Alec Brown <alec.r.brown@oracle.com>
---
grub-core/net/arp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/grub-core/net/arp.c b/grub-core/net/arp.c
index 54306e3b1..2b3765932 100644
--- a/grub-core/net/arp.c
+++ b/grub-core/net/arp.c
@@ -115,7 +115,8 @@ grub_net_arp_receive (struct grub_net_buff *nb, struct
grub_net_card *card,
grub_uint16_t *vlantag)
{
struct arppkt *arp_packet = (struct arppkt *) nb->data;
- grub_net_network_level_address_t sender_addr, target_addr;
+ grub_net_network_level_address_t sender_addr = {};
+ grub_net_network_level_address_t target_addr = {};
grub_net_link_level_address_t sender_mac_addr;
struct grub_net_network_level_interface *inf;
--
2.27.0
- [PATCH 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Alec Brown, 2022/03/15
- [PATCH 3/7] grub-core/net/arp.c: Fix uninitialized scalar variable,
Alec Brown <=
- [PATCH 2/7] grub-core/loader/i386/pc/linux.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 7/7] grub-core/net/bootp.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 1/7] grub-core/loader/i386/bsd.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 4/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 5/7] grub-core/net/net.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- [PATCH 6/7] grub-core/loader/i386/xnu.c: Fix uninitialized scalar variable, Alec Brown, 2022/03/15
- Re: [PATCH 0/7] Fix coverity uninitialized scalar variable bugs in grub-core, Darren Kenny, 2022/03/15