Re: [PATCH v3 1/2] lsefi: fixed memory leaks

[Renaud Métrich]

Right, sorry for that!

The patch was brought in RH grub (git@github.com:rhboot/grub2.git) by 
pjones in 2017:

commit c925abf2462e30ac76cba760e727fb953daf1aeb
Author: Peter Jones <pjones@redhat.com>
Date:   Thu Jun 1 09:59:56 2017 -0400

    Add grub_efi_allocate_pool() and grub_efi_free_pool() wrappers.

    Signed-off-by: Peter Jones <pjones@redhat.com>


Le 2/24/22 à 20:39, Daniel Kiper a écrit :
> On Tue, Feb 15, 2022 at 02:05:21PM +0100, Renaud Métrich wrote:
> > Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
> > ---
> >   grub-core/commands/efi/lsefi.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/grub-core/commands/efi/lsefi.c b/grub-core/commands/efi/lsefi.c
> > index d1ce99af4..b1f2d4695 100644
> > --- a/grub-core/commands/efi/lsefi.c
> > +++ b/grub-core/commands/efi/lsefi.c
> > @@ -136,8 +136,12 @@ grub_cmd_lsefi (grub_command_t cmd __attribute__ 
> > ((unused)),
> >                          (unsigned) protocols[j]->data4[7]);
> >         }
> >
> > +      if (protocols)
> > +       grub_efi_free_pool (protocols);
> The grub_efi_free_pool() does not exist in upstream. I think we are
> missing a patch from downstream.
>
> Daniel
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel

OpenPGP_signature
Description: OpenPGP digital signature