grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Retire ChangeLog-2015


From: Daniel Kiper
Subject: Re: [PATCH] Retire ChangeLog-2015
Date: Fri, 25 Feb 2022 13:03:48 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Fri, Feb 25, 2022 at 11:33:09AM +0100, Javier Martinez Canillas wrote:
> Hello Peter,
>
> Thanks a lot for your patch.
>
> On 2/24/22 22:55, Peter Jones wrote:
> > ChangeLog-2015 has been untouched for over 7 years now, and any
> > information in it is purely for historical purposes.  At the same time,
> > grepping for code winds up matching this file quite a bit, almost never
> > accomplishing anything other than cluttering up your grep results.  We
> > don't need this in the main repo, and "git show" will find it if you're
> > looking at the old history of commits on some file.
> >
> > This patch deletes it.
>
> Yes, let's *please* get rid of this ChangeLog. It doesn't add any
> value AFAICT and makes doing greps over the codebase much harder.
>
> > Signed-off-by: Peter Jones <pjones@redhat.com>
> > Reviewed-by: Daniel Axtens <dja@axtens.net>
> > Reviewed-by: Robbie Harwood <rharwood@redhat.com>
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

I agree with above but it requires more than just ChangeLog-2015 file
removal. The file is referenced at least in Makefile.am. Additionally,
may we consider addition of a script which generates ChangeLog file
from the git log? I think we could steal it from here [1][2]. And if we
do that I think we could drop NEWS file too (it is referenced in README;
so, it should be dropped from there too).

Daniel

[1] 
https://sourceware.org/git/?p=glibc.git;a=commit;h=2e4e75727eb05eef4c10470d865bd42962d5fae7
[2] 
https://sourceware.org/git/?p=glibc.git;a=commit;h=f2144b7874b23be7c7eb184ec601633ec6fa8fac



reply via email to

[Prev in Thread] Current Thread [Next in Thread]