[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 0/4] Update gnulib and drop some patches

From: Robbie Harwood
Subject: Re: [PATCH v5 0/4] Update gnulib and drop some patches
Date: Thu, 24 Feb 2022 14:43:21 -0500

Daniel Kiper <> writes:

> Robbie Harwood wrote:
>> Also, gnulib's position on sign comparison issues is to ignore them,
>> so the "fix" from our end would probably be to pragma them
> Huh! Where did you see that? Could you point me a source where they
> say that thing?

"If -Wsign-compare complains, let's disable -Wsign-compare instead of
changing carefully-written signed integers to be unsigned."

from subthread starting here:
on a patch I proposed to fix a bunch of their sign comparison issues
(originally written by pjones).

>> away... but that assumes this is the only issue, which hasn't been
>> checked yet.
> I am not sure what you mean here.

I mean that there may be other issues lurking when building with that
gcc version, which there were, but they're fixed in the v6 I sent.

Be well,

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]