[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] configure: Properly handle MM_DEBUG
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH 1/3] configure: Properly handle MM_DEBUG |
|
Date: |
Tue, 22 Feb 2022 19:00:47 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Feb 15, 2022 at 12:36:41PM -0600, Glenn Washburn wrote:
> Define MM_DEBUG in config.h when --enable-mm-debug is passed to configure.
> It was being defined in config-util.h which only gets used when building
> GRUB utilities for the host side. The enabling of debugging for memory
> management in include/grub/mm.h explicitly does not happen when compiling
> for the GRUB utilities. So this debugging code effectively could never be
> enabled. Note, that MM_DEBUG is defined in an #if directive because the
> enabling of debugging checks if MM_DEBUG is defined, not what its value is.
> So even if MM_DEBUG were defined to nothing, the debugging code would
> still be enabled.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel