[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 08/15] grub-shell: Only cleanup working directory file if QEMU
From: |
Glenn Washburn |
Subject: |
[PATCH v3 08/15] grub-shell: Only cleanup working directory file if QEMU does not fail or timeout |
Date: |
Thu, 10 Feb 2022 15:51:25 -0600 |
This keeps the generated files to aid in diagnosing the source of the
failure.
Signed-off-by: Glenn Washburn <development@efficientek.com>
---
tests/util/grub-shell.in | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in
index 3ba539c70..96869184c 100644
--- a/tests/util/grub-shell.in
+++ b/tests/util/grub-shell.in
@@ -533,8 +533,6 @@ elif [ x$boot = xemu ]; then
(cd "$rootdir"; tar cf "$roottar" .)
setup_qemu_logger
@builddir@/grub-core/grub-emu -m "$device_map" --memdisk "$roottar" -r
memdisk -d "/boot/grub" > "$work_directory/qemu-pipe" || ret=$?
- test -n "$debug" || rm -rf "$rootdir"
- test -n "$debug" || rm -f "$roottar"
else
setup_qemu_logger
timeout -s KILL $timeout "${qemu}" ${qemuopts} ${serial_null} -serial
file:/dev/stdout -${device}"${isofile}" ${bootdev} >
"$work_directory/qemu-pipe" || ret=$?
@@ -543,8 +541,16 @@ fi
wait
rm -f "$work_directory/qemu-pipe"
+if [ "$ret" -ne 0 ]; then
+ # If QEMU failure, keep generated files to reproduce
+ exit $ret
+fi
+
if [ x$boot = xcoreboot ]; then
test -n "$debug" || rm -f "${imgfile}"
+elif [ x$boot = xemu ]; then
+ test -n "$debug" || rm -rf "$rootdir"
+ test -n "$debug" || rm -f "$roottar"
fi
test -n "$debug" || rm -f "${isofile}"
test -n "$debug" || rm -rf "${rom_directory}"
--
2.27.0
- [PATCH v3 00/15] Grub-shell improvements, Glenn Washburn, 2022/02/10
- [PATCH v3 01/15] grub-shell: Allow specifying non-default trim line contents, Glenn Washburn, 2022/02/10
- [PATCH v3 02/15] grub-shell: Trim line should always be matched from the beginning of the line, Glenn Washburn, 2022/02/10
- [PATCH v3 03/15] grub-shell: Only show grub-mkrescue output if it returns an error, Glenn Washburn, 2022/02/10
- [PATCH v3 04/15] grub-shell: Allow setting default timeout via GRUB_SHELL_DEFAULT_TIMEOUT envvar, Glenn Washburn, 2022/02/10
- [PATCH v3 05/15] grub-shell: Put all generated files into working dir and use better file names, Glenn Washburn, 2022/02/10
- [PATCH v3 06/15] grub-shell: Add grub output logfile with grub-shell --debug, Glenn Washburn, 2022/02/10
- [PATCH v3 07/15] grub-shell: Set exit status to qemu exit status, Glenn Washburn, 2022/02/10
- [PATCH v3 08/15] grub-shell: Only cleanup working directory file if QEMU does not fail or timeout,
Glenn Washburn <=
- [PATCH v3 09/15] grub-shell: Create run.sh in working directory for easily running test again, Glenn Washburn, 2022/02/10
- [PATCH v3 10/15] grub-shell: Add $GRUB_QEMU_OPTS to run.sh to easily see unofficial QEMU arguments, Glenn Washburn, 2022/02/10
- [PATCH v3 11/15] tests: Allow turning on shell tracing from environment variables, Glenn Washburn, 2022/02/10
- [PATCH v3 12/15] grub-shell: Add --verbose to mkrescue when $debug is greater than 2, Glenn Washburn, 2022/02/10
- [PATCH v3 14/15] grub-shell: Use malta qemu-mips machine type instead off non-existant indy, Glenn Washburn, 2022/02/10
- [PATCH v3 13/15] grub-shell: Only turn on qemu head when large debug value is specified, Glenn Washburn, 2022/02/10
- [PATCH v3 15/15] grub-shell: Add flexibility in QEMU firmware handling, Glenn Washburn, 2022/02/10