[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Revert "iee1275/datetime: Fix off-by-1 error."
From: |
Daniel Kiper |
Subject: |
Re: [PATCH] Revert "iee1275/datetime: Fix off-by-1 error." |
Date: |
Wed, 9 Feb 2022 21:40:13 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Feb 08, 2022 at 03:51:41PM +1100, Daniel Axtens wrote:
> Hi,
>
> I tested a pseries guest under:
> - qemu + KVM on a Power8 host with a fairly modern qemu
> - qemu + TCG
>
> Here the 'date' command simply reports "error: no cmos found", so
> this patch will have no impact on those platforms.
>
> I also tested an LPAR on a Power8 PowerVM machine. In this case, before
> the patch, grub printed:
>
> grub> date
> 2022-02-09 04:31:10 Wednesday
>
> whereas on booting:
>
> [dja@sauce ~]$ date -u
> Tue Feb 8 04:46:40 UTC 2022
>
> After applying the patch, grub printed:
>
> grub> date
> 2022-02-08 04:51:27 Tuesday
>
> It seems the patch makes things better.
>
> Tested-by: Daniel Axtens <dja@axtens.net>
Daniel, thank you for testing this!
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel