[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] EFI: console: Do not set cursor until the first text out

From: Javier Martinez Canillas
Subject: Re: [PATCH 2/2] EFI: console: Do not set cursor until the first text output
Date: Sun, 30 Jan 2022 14:35:46 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 1/28/22 12:43, Hans de Goede wrote:
> To allow flickerfree boot the EFI console code does not call
> grub_efi_set_text_mode (1) until some text is actually output.
> Depending on if the output text is because of an error loading
> e.g. the .cfg file; or because of showing the menu the cursor needs
> to be on or off when the first text is shown.
> So far the cursor was hardcoded to being on, but this is causing
> drawing artifacts + slow drawing of the menu as reported here:
> Handle the cursorstate in the same way as the colorstate to fix this,
> when no text has been output yet, just cache the cursorstate and
> then use the last set value when the first text is output.
> Fixes: 2d7c3abd871f ("efi/console: Do not set text-mode until we actually 
> need it")
> Signed-off-by: Hans de Goede <>
> ---

Reviewed-by: Javier Martinez Canillas <>

Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat

reply via email to

[Prev in Thread] Current Thread [Next in Thread]