grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 5/7] cryptodisk: enable the backends to implement key file


From: Glenn Washburn
Subject: Re: [PATCH v8 5/7] cryptodisk: enable the backends to implement key files
Date: Tue, 4 Jan 2022 15:49:58 -0600

On Tue, 4 Jan 2022 15:46:19 -0600
Glenn Washburn <development@efficientek.com> wrote:

> Also from Dmitry.
> 
> On Tue, 4 Jan 2022 21:25:14 +0300
> Dmitry <reagentoo@gmail.com> wrote:
> 
> > From: John Lane <john@lane.uk.net>
> > 
> > Signed-off-by: John Lane <john@lane.uk.net>
> > GNUtoo@cyberdimension.org: rebase, patch split, small fixes, commit message
> > Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
> > development@efficientek.com: rebase and rework to use cryptomount arg 
> > passing
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > ---
> >  grub-core/disk/cryptodisk.c | 83 +++++++++++++++++++++++++++++++++++++
> >  include/grub/cryptodisk.h   |  2 +
> >  include/grub/file.h         |  2 +
> >  3 files changed, 87 insertions(+)
> > 
> > diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c
> > index e90f680f0..ea8ed20e2 100644
> > --- a/grub-core/disk/cryptodisk.c
> > +++ b/grub-core/disk/cryptodisk.c
> > @@ -43,6 +43,9 @@ static const struct grub_arg_option options[] =
> >      {"boot", 'b', 0, N_("Mount all volumes with `boot' flag set."), 0, 0},
> >      {"password", 'p', 0, N_("Password to open volumes."), 0, 
> > ARG_TYPE_STRING},
> >      {"header", 'H', 0, N_("Read header from file"), 0, ARG_TYPE_STRING},
> > +    {"keyfile", 'k', 0, N_("Key file"), 0, ARG_TYPE_STRING},
> 
> You have custom options --header, --keyfile. I suggest renaming in a
> similar 
> way as in cryptsetup(8) - --header, --key-file, (--master-key-file)

I think sounds reasonable. I'll change this in the next version unless
I hear a good reason not too.

Glenn



reply via email to

[Prev in Thread] Current Thread [Next in Thread]