Re: [PATCH v2] misc: Allow selective disabling of debug facility names

[Michael Schierl]

Hello Glenn,


Am 07.12.2021 um 22:59 schrieb Glenn Washburn:
> Yes, but I didn't want to assume that "all" is the first item in the
> list.

More important, "all" does not have to be present at all.

DEBUG=fat,btrfs,-fat

should be perfectly legal (and it is).

> I decided that it doesn't make as much sense to have the position of
> "all" matter, and effectively be a macro for all conditionals, because
> at that point why append ",all,...", just set debug to "all,..."
> erasing the previous contents.

That is a fair point. Same applies to "-all" (just erase everything in
the string before it).

Instead of

DEBUG=btrfs,all,fat,-all,ext2

probably the user just wanted to enter

DEBUG=ext2

> I'm open to suggestions on what the preferred way to handle this might
> be. We could say that "all" must appear at the beginning, but that
> seems unnecessary and overly restrictive. What's less clear to me is
> what situation I might want to put have "all" not at the beginning of
> the string. I'm thinking there might be one, which is why I'm leaving
> that as an option, but maybe I'm wrong.

I cannot think of any sensible one that would not confuse the user, like
your example with

DEBUG=-btrfs,all,-fat

But I don't think we have to put too much effort in it, especially since
the code should also work in case "all" is not present at all.


Regards,


Michael