[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/19] grub-shell: Boot PowerPC using PMU instead of CUDA for
From: |
Daniel Kiper |
Subject: |
Re: [PATCH 01/19] grub-shell: Boot PowerPC using PMU instead of CUDA for power management |
Date: |
Wed, 20 Oct 2021 17:39:37 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Oct 12, 2021 at 12:11:30PM -0500, Glenn Washburn wrote:
> On Tue, 12 Oct 2021 18:29:50 +1100
> Daniel Axtens <dja@axtens.net> wrote:
>
> > From: Glenn Washburn <development@efficientek.com>
> >
> > A recent refactoring of CUDA command code has exposed a bug in OpenBIOS[1]
> > which was causing system powerdown and system reset to fail, thus causing
> > the Qemu instance to hang. This in turn caused the grub-shell command to
> > timeout causing it to return an error code when the test actually completed
> > successfully.
> >
> > Since it could be a while before the patch fixing this issue in OpenBIOS
> > filters down to the average distro, switch to PMU to allow powerdowns and
> > reboots to work as expected.
> >
> > [1] https://gitlab.com/qemu-project/qemu/-/issues/624
> >
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > [dja: unbreak pseries]
> > Signed-off-by: Daniel Axtens <dja@axtens.net>
> > ---
> > tests/util/grub-shell.in | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in
> > index 93e9f5148408..33590baeb13c 100644
> > --- a/tests/util/grub-shell.in
> > +++ b/tests/util/grub-shell.in
> > @@ -84,6 +84,7 @@ case
> > "${grub_modinfo_target_cpu}-${grub_modinfo_platform}" in
> > serial_null="-serial null"
> > netbootext=elf
> > trim=1
> > + qemuopts="-M mac99,via=pmu $qemuopts"
> > ;;
> >
> > sparc64-ieee1275)
> > @@ -231,7 +232,7 @@ for option in "$@"; do
> > qemu=qemu-system-ppc64
> > serial_port=ieee1275/hvterm
> > serial_null=
> > - qemuopts="$qemuopts -M pseries -no-reboot"
> > + qemuopts="$(echo $qemuopts | sed -E 's/-M [^ ]+//') -M pseries
> > -no-reboot"
>
> LGTM.
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
- [PATCH 00/19] Requesting more memory from firmware, Daniel Axtens, 2021/10/12
- [PATCH 03/19] mm: document grub internal memory management structures, Daniel Axtens, 2021/10/12
- [PATCH 01/19] grub-shell: Boot PowerPC using PMU instead of CUDA for power management, Daniel Axtens, 2021/10/12
- [PATCH 04/19] mm: assert that we preserve header vs region alignment, Daniel Axtens, 2021/10/12
- [PATCH 02/19] grub-shell: pseries: don't pass fw_opt to qemu, Daniel Axtens, 2021/10/12
- [PATCH 05/19] mm: when adding a region, merge with region after as well as before, Daniel Axtens, 2021/10/12
- [PATCH 06/19] configure: properly pass through MM_DEBUG, Daniel Axtens, 2021/10/12
- [PATCH 07/19] Add memtool module with memory allocation stress-test, Daniel Axtens, 2021/10/12
- [PATCH 08/19] mm: Drop unused unloading of modules on OOM, Daniel Axtens, 2021/10/12