[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses.
From: |
Glenn Washburn |
Subject: |
Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses. |
Date: |
Tue, 19 Oct 2021 16:57:09 -0500 |
On Tue, 19 Oct 2021 17:08:59 -0400
Robbie Harwood <rharwood@redhat.com> wrote:
> Glenn Washburn <development@efficientek.com> writes:
>
> > I don't think we need to agree (that is for you to agree that the issue
> > I'm describing is something to be concerned about). However, like I
> > said, I think we can both be satisfied by not leaving out the file:line
> > and to prepend "\n" to "add-symbol-file" so that it will start on a new
> > line. So I'll ask again. Is my proposal an acceptable modification for
> > the need that you have?
>
> No, this is what I was trying to explain. There's one add-symbol-file
> line per module. If there's no file:line, you get something like this:
>
> add-symbol-file ...
> add-symbol-file ...
> add-symbol-file ...
>
> This can be directly pasted into gdb.
Thank you for clarifying that for me. Technically the patch prints a
multiline debug message, so you don't get one line per module. However,
I see that doesn't matter for your use case because the line
continuation makes it appear as one line in gdb.
>
> Your proposal results in something like:
>
> dl.c:694:
> add-symbol-file ...
> dl.c:694:
> add-symbol-file ...
> dl.c:694:
> add-symbol-file ...
>
> You can't easily copy-paste that into gdb. It needs to be processed to
> remove the file:line stuff.
Ok, I see now why removing the prefix is important for you. And my
objection still stands. At worst just copy into a file and run grep -v
or sed. There have been alternatives proposed on this thread which may
be preferable.
Glenn
- [PATCH 0/2] Print out load addresses for .text and .data, Robbie Harwood, 2021/10/11
- [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses., Robbie Harwood, 2021/10/11
- Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses., Glenn Washburn, 2021/10/12
- Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses., Robbie Harwood, 2021/10/14
- Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses., Glenn Washburn, 2021/10/15
- Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses., Robbie Harwood, 2021/10/15
- Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses., Glenn Washburn, 2021/10/15
- Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses., Robbie Harwood, 2021/10/19
- Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses.,
Glenn Washburn <=
- Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses., Thomas Schmitt, 2021/10/20
[PATCH 1/2] Add grub_qdprintf() - grub_dprintf() without the file+line number., Robbie Harwood, 2021/10/11