Re: [PATCH 02/19] grub-shell: pseries: don't pass fw_opt to qemu

[Glenn Washburn]

On Tue, 12 Oct 2021 18:29:51 +1100
Daniel Axtens <dja@axtens.net> wrote:

> At some point this started to break the test - qemu just rejects the
> command line. Just don't pass it in, it's seabios specific.
> 
> Signed-off-by: Daniel Axtens <dja@axtens.net>
> ---
>  tests/util/grub-shell.in | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in
> index 33590baeb13c..92c0b6f320c3 100644
> --- a/tests/util/grub-shell.in
> +++ b/tests/util/grub-shell.in
> @@ -376,7 +376,11 @@ if test -z "$debug"; then
>    # workaround unfortunately causes qemu to issue a warning 'externally
>    # provided fw_cfg item names should be prefixed with "opt/"', but there
>    # doesn't seem to be a better option.
> -  qemuopts="${qemuopts} -fw_cfg name=etc/sercon-port,string=0"
> +  #
> +  # Don't do this on pseries, it breaks recent qemus.
> +  if [ $pseries == n ]; then
> +    qemuopts="${qemuopts} -fw_cfg name=etc/sercon-port,string=0"

I've confirmed that this is an issue on Qemu 5.2 from Debian 11 and
that this patch works as advertised. The better solution would only be
added on targets using SeaBIOS. This would only be i386, right? There
is an HPPA port, but I don't think we support that architecture.

> +  fi
>  fi
>  
>  if [ x$boot != xnet ] && [ x$boot != xemu ]; then

Tested-by: Glenn Washburn <development@efficientek.com>

Glenn