Re: [PATCH v2 7/8] tests: Exit with skipped exit code when test not performed

[Daniel Kiper]

On Fri, Sep 17, 2021 at 09:42:49PM +0000, Glenn Washburn wrote:
> On Wed, 25 Aug 2021 02:04:01 -0500
> Glenn Washburn <development@efficientek.com> wrote:
>
> > These tests were not performed and therefore did not pass, nor fail.
> > This fixes misleading test exit code where, for instance, the
> > pseries_test will pass on i386-pc, which is not a pseries
> > architecture.
> >
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > ---
> >  tests/ahci_test.in          |  8 ++++----
> >  tests/cdboot_test.in        |  8 ++++----
> >  tests/core_compress_test.in |  2 +-
> >  tests/ehci_test.in          |  8 ++++----
> >  tests/fddboot_test.in       | 16 ++++++++--------
> >  tests/grub_cmd_date.in      |  2 +-
> >  tests/grub_cmd_set_date.in  |  6 +++---
> >  tests/hddboot_test.in       |  6 +++---
> >  tests/netboot_test.in       | 12 ++++++------
> >  tests/ohci_test.in          |  8 ++++----
> >  tests/partmap_test.in       |  8 ++++----
> >  tests/pata_test.in          |  6 +++---
> >  tests/pseries_test.in       |  2 +-
> >  tests/uhci_test.in          |  8 ++++----
> >  14 files changed, 50 insertions(+), 50 deletions(-)
>
> I missed that the test for grub_cmd_sleep.in on sparc64-ieee1275 should
> be skipped as well. Its a trivial change and will add it on the next
> revision of this series after review.

You can add "Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>" to
this patch too...

Daniel