[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] templates: Add GRUB_CMDLINE_LINUX_RECOVERY
From: |
Daniel Kiper |
Subject: |
Re: [PATCH] templates: Add GRUB_CMDLINE_LINUX_RECOVERY |
Date: |
Wed, 15 Sep 2021 17:12:10 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, Sep 15, 2021 at 03:18:40PM +0200, Paul Menzel wrote:
> [Cc: +Kyle]
>
> Am 14.09.21 um 21:25 schrieb chris@z9.de:
> > From: Chris Vogel <chris@z9.de>
> >
> > When generating grub.cfg using grub-mkconfig and the scripts 10_linux and
> > 20_linux_xen there is no way to add kernel command line parameters _only_ to
> > the recovery entries generated.
> >
> > This is needed to e.g. start a debug shell in installations using systemd
> > using the kernel command line parameter "systemd.debug-shell" or to recover
> > in a system with encrypted root in situations where the decryption of the
> > root filesystem per crypttab in the intiramfs image is broken and the
> > recovery
> > entry should contain informations about how to decrypt the rootfs
> > (cryptopts=).
> >
> > This patch does not change the default behaviour of grub if
> > GRUB_CMDLINE_LINUX_RECOVERY is not set.
> >
> > If GRUB_CMDLINE_LINUX_RECOVERY is set and the generated recovery entry
> > should
> > include the kernel parameter 'single' the parameter must be explicitly
> > included
> > in GRUB_CMDLINE_LINUX_RECOVERY.
> >
> > As far as I know all credits for the idea and the initial implementation go
> > to
> > Kyle Ranking of Purism.
> >
"Signed-off-by: Kyle Rankin <kyle.rankin@puri.sm>" is missing here.
I can add it before committing the patch if Kyle does not object of
course... :-)
> > Signed-off-by: Chris Vogel <chris@z9.de>
Otherwise: Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel