Re: IS: Glenn's patches status WAS: Re: [PATCH 00/12] Grub-shell improvements

[Glenn Washburn]

On Tue, 14 Sep 2021 13:04:31 +0200
Daniel Kiper <daniel.kiper@oracle.com> wrote:

> On Mon, Aug 30, 2021 at 05:23:44PM +0200, Daniel Kiper wrote:
> > CC-ing Denis and Patrick...
> >
> > On Thu, Aug 26, 2021 at 05:08:21PM -0500, Glenn Washburn wrote:
> > > Hi Daniel,
> > >
> > > On Thu, 26 Aug 2021 20:00:32 +0200
> > > Daniel Kiper <daniel.kiper@oracle.com> wrote:
> > >
> > > > Hi Glenn,
> > > >
> > > > On Wed, Aug 25, 2021 at 06:06:30PM -0500, Glenn Washburn wrote:
> > > > > Hi Daniel,
> 
> [...]
> 
> > > As far as I can tell, this is the full list.
> >
> > Great!
> 
> It looks I missed at least this one:
>   - [PATCH 00/17] Fixes and improvements for cryptodisks+luks2 and a
> few other things.
> https://lists.gnu.org/archive/html/grub-devel/2020-07/msg00050.html
> 
> Do you still care about it?

No, these can be skipped. The changes in that patch series that aren't
integrated, are in other patch series or I'll send to the list in the
future.

> > > My order preference is as follows:
> > >
> > > These two patches are only first because it should be a quick
> > > review.
> > >   - [PATCH] command: Add silent mode to read command to suppress
> > >     input echo
> > >     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00291.html
> > >   - [PATCH] fs: Allow number of blocks in block list to be
> > > optional, defaulting length to device length
> > >     https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00286.html
> >
> > OK.
> 
> I merged them yesterday.

Thanks!

> > > This is a high priority because I think it should be merged
> > > before the keyfile and detached header support patch series. If
> > > this is merged, I'll submit and updated keyfile and detached
> > > header patch series that works with this patch series.
> > >   - [PATCH 0/3] Refactor/improve cryptomount data passing to
> > > crypto modules
> > >     https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00129.html
> >
> > Denis, Patrick, are you both OK with this?
> 
> I can see a discussion about this patch set. Should I wait for a new
> version for review?

Yes, there will be a new version of the patch series coming. I'm
waiting to tie up the last concern of Patrick's.

> > > Based on discussion with Thomas Schmitt, I think the first patch
> > > of this series should be dropped. Should I make a v3, or would
> > > you review it and if acceptable drop the first patch?
> > >   - [PATCH v2 0/8] Various fixes/improvements for tests
> > >     https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00110.html
> 
> Next on my list for review...
> 
> Daniel

Great! I also have some more testing fixes / changes coming in this
vein.

Glenn