grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/5] powerpc: drop Open Hack'Ware


From: Daniel Axtens
Subject: [PATCH 1/5] powerpc: drop Open Hack'Ware
Date: Mon, 6 Sep 2021 15:46:11 +1000

Open Hack'Ware was an alternative firmware of powerpc under qemu.

The last commit to any Open Hack'Ware repo I can find is from 2014.[1]

Open Hack'Ware was used for the qemu "prep" machine type, which was
deprecated in qemu in commit 54c86f5a4844 ("hw/ppc: deprecate the
machine type 'prep', replaced by '40p'") in qemu v3.1, and had reportedly
been broken for years before without anyone noticing. Support was removed
in Feburary 2020 by commit b2ce76a0730e ("hw/ppc/prep: Remove the
deprecated "prep" machine and the OpenHackware BIOS").

Open Hack'Ware's limitations require some messy code in grub. This
complexity is not worth carrying any more.

Remove detection of Open Hack'Ware. We will clean up the feature flags
in following commits.

[1]: https://github.com/qemu/openhackware and
     https://repo.or.cz/w/openhackware.git are qemu submodules. They have
     only small changes on top of OHW v0.4.1, which was imported into
     qemu SCM in 2010. I can't find anything resembling an official repo
     any more.

Signed-off-by: Daniel Axtens <dja@axtens.net>
---
 grub-core/kern/ieee1275/cmain.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/grub-core/kern/ieee1275/cmain.c b/grub-core/kern/ieee1275/cmain.c
index 20cbbd761ec3..4442b6a83193 100644
--- a/grub-core/kern/ieee1275/cmain.c
+++ b/grub-core/kern/ieee1275/cmain.c
@@ -49,7 +49,6 @@ grub_ieee1275_find_options (void)
   grub_ieee1275_phandle_t root;
   grub_ieee1275_phandle_t options;
   grub_ieee1275_phandle_t openprom;
-  grub_ieee1275_phandle_t bootrom;
   int rc;
   grub_uint32_t realmode = 0;
   char tmp[256];
@@ -190,21 +189,6 @@ grub_ieee1275_find_options (void)
 
       grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_HAS_CURSORONOFF);
     }
-
-  if (! grub_ieee1275_finddevice ("/rom/boot-rom", &bootrom)
-      || ! grub_ieee1275_finddevice ("/boot-rom", &bootrom))
-    {
-      rc = grub_ieee1275_get_property (bootrom, "model", tmp, sizeof (tmp), 0);
-      if (rc >= 0 && !grub_strncmp (tmp, "PPC Open Hack'Ware",
-                                   sizeof ("PPC Open Hack'Ware") - 1))
-       {
-         grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_BROKEN_OUTPUT);
-         grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_CANNOT_SET_COLORS);
-         grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_CANNOT_INTERPRET);
-         grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_FORCE_CLAIM);
-         grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_NO_ANSI);
-       }
-    }
 }
 
 void
-- 
2.30.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]