[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] autogen.sh: Detect python
From: |
Petr Vorel |
Subject: |
Re: [PATCH v2 2/2] autogen.sh: Detect python |
Date: |
Fri, 3 Sep 2021 12:49:55 +0200 |
Hi Daniel,
> On Mon, Aug 30, 2021 at 11:53:17AM +0200, Petr Vorel wrote:
> > It help to avoid error on distros which has only python3 binary:
> > ./autogen.sh: line 20: python: command not found
> > Use python3 as the default as python2 is EOL since Jan 2020, but check
> > also python which is on most distros if not all python2 because
> > code still works on python2.
> > Although it should not be needed keep the possibility to define PYTHON.
> > For detection use "command -v" which is POSIX [3] and supported on all
> > common shells (bash, zsh, dash, busybox sh, mksh) instead requiring
> > "which" as extra dependency (usable on containers).
> > Update INSTALL.
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> I think you missed some minor requests from previous review. I can fix
> them before committing. Anyway, Reviewed-by: Daniel Kiper
> <daniel.kiper@oracle.com>
> for both patches...
Not sure what I left, but sure, feel free to further tweak it before merge.
Kind regards,
Petr
> Thank you for fixing these issues.
> Daniel
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 2/2] autogen.sh: Detect python,
Petr Vorel <=