grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/7] Add LoadFile2 and riscv Linux loader


From: Nikita Ermakov
Subject: Re: [PATCH v2 0/7] Add LoadFile2 and riscv Linux loader
Date: Sun, 29 Aug 2021 15:44:04 +0300

Btw, I have a minor suggestion [1] for your patch.
AFAIK hartid terminology and /chosen/boot-hartid are RISC-V specifics. So, I think, we should not emit the warning and change DTB with a null boot-hartid value. If get_hartid is not defined then we should, probably, just skip this boot-hartid thing.

What do you think? If it is alright I can change your patch with these changes and send V3 or you can change it by yourself.

[1] https://github.com/sh1r4s3/grub/commit/af66530842dd3058e1ac0acd8e4ddfd51671fa6c

--
Thanks,
Nikita
B8 4C 00 CD 21

нд, 29 серп. 2021, 05:30 користувач Fu Wei <tekkamanninja@gmail.com> пише:
Hi Nikita,

Nikita Ermakov <arei@altlinux.org> 于2021年8月28日周六 下午8:22写道:
>
> Hi Atish, Fu,
>
> On Fri, 27 Aug 2021 at 19:29, Fu Wei <tekkamanninja@gmail.com> wrote:
> >
> > Hi Atish,
> >
> > Great thanks for adding me the loop!
> >
> > I have tested this these whole patchset on Starlight board and Allwinner D1 ,
> >
> > https://github.com/tekkamanninja/grub/tree/riscv_devel_Nikita_V2
> >
> > I would be nice If you can add my Tested-by for this patchset!
> >
> > Tested-by: Wei Fu <tekkamanninja@gmail.com>
> >
> Fu, thank you for the test and the patch regarding boot-hartid.
> I can send V3 with "Tested-by: Wei Fu <tekkamanninja@gmail.com>"
> appended to the patchset and add the 8'th patch to set boot-hartid.
> Is it ok?

Sure , NP :-) .
Please add my Tested-by :-)

>
> > Atish Patra <atishp@atishpatra.org> 于2021年8月28日周六 上午12:22写道:
> > >
> > > On Wed, Jun 2, 2021 at 2:13 PM Nikita Ermakov <arei@altlinux.org> wrote:
> > > >
> > > > Hello,
> > > >
> > > > This is the second version of the patch series. The patch series is almost the
> > > > same as the previous one except that the Heinrich's suggestions were
> > > > implemented.
> > > >
> > > > This series contains patches to add support for LoadFile2 protocol to load
> > > > initrd on EFI systems. Also it contains patches to load Linux kernel with EFI
> > > > stub on riscv platforms and unites arm and riscv codes together into common
> > > > loader code for EFI systems.
> > >
> > > + Wei Fu who tested this series on Beagleboard.
> > >
> > > According to Wei we do another patch to add a boot-hartid entry in the
> > > chosen node if DTB is
> > > loaded from grub instead of U-Boot [1].
> > >
> > > [1] https://github.com/tekkamanninja/grub/commit/99c5dc1ba897e506f185eb19d4dadc6d41937214
> > > >
> > > > Ard Biesheuvel (3):
> > > >   efi: add definition of LoadFile2 protocol
> > > >   efi: implemented LoadFile2 initrd loading protocol for Linux
> > > >   linux: ignore FDT unless we need to modify it
> > > >
> > > > Atish Patra (3):
> > > >   loader: Move arm64 linux loader to common code
> > > >   RISC-V: Update image header
> > > >   RISC-V: Use common linux loader
> > > >
> > > > Nikita Ermakov (1):
> > > >   loader: drop argv[] argument in grub_initrd_load()
> > > >
> > > >  grub-core/Makefile.core.def               |   8 +-
> > > >  grub-core/commands/efi/lsefi.c            |   1 +
> > > >  grub-core/loader/arm/linux.c              |   2 +-
> > > >  grub-core/loader/efi/fdt.c                |   7 +-
> > > >  grub-core/loader/{arm64 => efi}/linux.c   | 143 +++++++++++++++++++---
> > > >  grub-core/loader/i386/linux.c             |   2 +-
> > > >  grub-core/loader/i386/pc/linux.c          |   2 +-
> > > >  grub-core/loader/i386/xen.c               |   3 +-
> > > >  grub-core/loader/ia64/efi/linux.c         |   2 +-
> > > >  grub-core/loader/linux.c                  |   4 +-
> > > >  grub-core/loader/mips/linux.c             |   2 +-
> > > >  grub-core/loader/powerpc/ieee1275/linux.c |   2 +-
> > > >  grub-core/loader/riscv/linux.c            |  59 ---------
> > > >  grub-core/loader/sparc64/ieee1275/linux.c |   2 +-
> > > >  include/grub/arm/linux.h                  |   2 +-
> > > >  include/grub/arm64/linux.h                |   2 +-
> > > >  include/grub/efi/api.h                    |  15 +++
> > > >  include/grub/linux.h                      |   2 +-
> > > >  include/grub/riscv32/linux.h              |  16 +--
> > > >  include/grub/riscv64/linux.h              |  16 +--
> > > >  20 files changed, 185 insertions(+), 107 deletions(-)
> > > >  rename grub-core/loader/{arm64 => efi}/linux.c (72%)
> > > >  delete mode 100644 grub-core/loader/riscv/linux.c
> > > >
> > > > --
> > > > 2.29.3
> > > >
> > > >
> > > > _______________________________________________
> > > > Grub-devel mailing list
> > > > Grub-devel@gnu.org
> > > > https://lists.gnu.org/mailman/listinfo/grub-devel
> > >
> > >
> > >
> > > --
> > > Regards,
> > > Atish
>
> --
> Thanks,
> Nikita
> B8 00 4C CD 21

reply via email to

[Prev in Thread] Current Thread [Next in Thread]