[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_tes
From: |
Thomas Schmitt |
Subject: |
Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test |
Date: |
Fri, 27 Aug 2021 23:23:26 +0200 |
Hi,
i wrote:
> > it might be contraproductive to set LANG=en_US.UTF-8.
Glenn Washburn wrote:
> My patch only sets LANG if empty, so in this case I don't think its
> counterproductive, just not productive.
Yes. It cautiously avoids to make the situation any worse.
I meant my own announced plan which was more agressively aiming for
enforcing UTF-8.
Well, i hope that my cheat sheet for (unsuccessful) kernel contribution
attempts enabled me to create a convincing imitation of an acceptable
patch for GRUB.
To help reading the oversized line salad:
I defined the variable XORRISOFS_CHARSET and added $XORRISOFS_CHARSET
after each "-as mkisofs" in the xorriso command lines.
Tests were made without any LANG setting (effectively en_US.utf-8),
with LANG="", "C", "en_US.ISO-8859-1" (not installed), "en_US.UTF-8",
"de_DE.UTF-8" (not installed). All succeeded.
Have a nice day :)
Thomas
- Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test, (continued)
- Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test, Thomas Schmitt, 2021/08/25
- Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test, Glenn Washburn, 2021/08/25
- Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test, Thomas Schmitt, 2021/08/26
- Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test, Glenn Washburn, 2021/08/26
- Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test, Thomas Schmitt, 2021/08/26
- Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test, Glenn Washburn, 2021/08/26
- Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test, Thomas Schmitt, 2021/08/26
- Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test, Glenn Washburn, 2021/08/26
- Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test, Thomas Schmitt, 2021/08/27
- Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test, Glenn Washburn, 2021/08/27
- Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test,
Thomas Schmitt <=
[PATCH v2 4/8] tests: Fail immediately when grub-shell fails and do not occlude the error code, Glenn Washburn, 2021/08/25
[PATCH v2 8/8] tests: Use @BUILD_SHEBANG@ autoconf var instead of literal shell, Glenn Washburn, 2021/08/25
[PATCH v2 3/8] tests: When checking squashfs fstime, use superblock last modified time, Glenn Washburn, 2021/08/25
[PATCH v2 5/8] tests: Make setup errors in grub-fs-tester hard errors, Glenn Washburn, 2021/08/25
[PATCH v2 6/8] tests: A failure of mktemp should cause the test script to exit with code 99, Glenn Washburn, 2021/08/25
[PATCH v2 7/8] tests: Exit with skipped exit code when test not performed, Glenn Washburn, 2021/08/25