grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] configure: Check -falign-jumps=1 -falign-functions=1 besi


From: Paul Menzel
Subject: Re: [PATCH v2] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1
Date: Tue, 24 Aug 2021 08:07:03 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

Dear Fāng-ruì,


Am 24.08.21 um 07:53 schrieb Fangrui Song via Grub-devel:
Clang does not support -falign-jumps and only recently gained support
for -falign-loops. Test all the alignment options to avoid passing
unrecognized options to Clang:

     clang-14: error: optimization flag '-falign-jumps=1' is not supported 
[-Werror,-Wignored-optimization-argument]

When compiled with older Clang, the alignment options are not added, so
just avoid the complexity for each option.

While here, remove checks for the obsoleted -malign-* forms.
GCC has supported the preferred -falign-* forms since 3.2.

Thank you for the cleanup. Could you put this in a separate commit please (and maybe order it first)?

Signed-off-by: Fangrui Song <maskray@google.com>
---
  configure.ac | 14 +++-----------
  1 file changed, 3 insertions(+), 11 deletions(-)

[…]


Kind regards,

Paul



reply via email to

[Prev in Thread] Current Thread [Next in Thread]