Re: [RFC PATCH v2] util/mkimage: Fix wrong PE32+ section sizes for some arches

[Javier Martinez Canillas]

Hello Adrian,

On 4/27/21 9:55 AM, John Paul Adrian Glaubitz wrote:
> Hi Javier!
> 
> On 4/26/21 7:18 PM, Daniel Kiper wrote:
>> (...)
>> I think this should be:
>>   layout->kernel_size = ALIGN_UP (layout->kernel_size, 
>> GRUB_PE32_FILE_ALIGNMENT);
>>
>> Here we care about alignment in the PE file not in the memory. So,
>> I think we have to use GRUB_PE32_FILE_ALIGNMENT instead. Though
>> the result is the same...
> 
> Let me know once you have a new version of the patch ready, I'll test it as 
> quickly
> as possible.
>

Thanks! I was busy this morning with other things but I'll post a v3 now.

I'll keep your Tested-by tag since the size calculated should be the same,
but would be good to test it again just to make sure that's the case.
 
> Adrian
> 

Best regards,
-- 
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat