grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2] util/mkimage: Fix wrong PE32+ section sizes for some


From: John Paul Adrian Glaubitz
Subject: Re: [RFC PATCH v2] util/mkimage: Fix wrong PE32+ section sizes for some arches
Date: Tue, 27 Apr 2021 09:55:05 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0

Hi Javier!

On 4/26/21 7:18 PM, Daniel Kiper wrote:
> (...)
> I think this should be:
>   layout->kernel_size = ALIGN_UP (layout->kernel_size, 
> GRUB_PE32_FILE_ALIGNMENT);
> 
> Here we care about alignment in the PE file not in the memory. So,
> I think we have to use GRUB_PE32_FILE_ALIGNMENT instead. Though
> the result is the same...

Let me know once you have a new version of the patch ready, I'll test it as 
quickly
as possible.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



reply via email to

[Prev in Thread] Current Thread [Next in Thread]