[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired
|
From: |
Javier Martinez Canillas |
|
Subject: |
Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired |
|
Date: |
Thu, 22 Apr 2021 17:15:31 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
Hello Vladimir,
On 4/22/21 4:56 PM, Vladimir 'phcoder' Serbinenko wrote:
> Filesystems are not mounted in GRUB. This patch will result in GRUB
> outputting a warning on every access to any XFS that has this flag set,
> even if it is not related to further booting. It will create an excessive
> noise. FS drivers shouldn't print anything except dprintf's
>
I see, you are right. There's a grub_xfs_mount() function in grub-core/fs/xfs.c
but it's misleading indeed since is just called from the .fs_* handlers to read
the data.
Do you think we should just ignore the flag then and drop this patch or it is
worth to have some debugging printouts with grub_dprintf("xfs", ... ) ?
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat