grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] ieee1275: request memory with ibm, client-architecture-s


From: Daniel Axtens
Subject: Re: [PATCH 3/3] ieee1275: request memory with ibm, client-architecture-support
Date: Tue, 20 Apr 2021 14:57:06 +1000

> diff --git a/grub-core/kern/ieee1275/cmain.c b/grub-core/kern/ieee1275/cmain.c
> index 20cbbd761ec3..35f2c573730f 100644
> --- a/grub-core/kern/ieee1275/cmain.c
> +++ b/grub-core/kern/ieee1275/cmain.c
> @@ -90,7 +90,10 @@ grub_ieee1275_find_options (void)
>    }
>  
>    if (rc >= 0 && grub_strncmp (tmp, "IBM", 3) == 0)
> -    grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_NO_TREE_SCANNING_FOR_DISKS);
> +    {
> +      grub_ieee1275_set_flag (GRUB_IEEE1275_FLAG_NO_TREE_SCANNING_FOR_DISKS);
> +      grub_ieee1275_set_flag 
> (GRUB_IEEE1275_FLAG_CAN_TRY_CAS_FOR_MORE_MEMORY);
> +    }

There's a bug here, I use /model to set the flag, not /compatible. The
test just has to move down in the function a bit. I'll send a new spin
in a couple of days once anyone interested has a chance to look at the
patch. Sorry about that, thought I had checked it, not quite sure what
went wrong.

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]