[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] i386-pc: build verifiers API as module
From: |
Michael Chang |
Subject: |
Re: [PATCH v2] i386-pc: build verifiers API as module |
Date: |
Tue, 13 Apr 2021 12:13:02 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Apr 12, 2021 at 03:15:53PM +0200, Daniel Kiper wrote:
> On Fri, Mar 26, 2021 at 06:01:01PM +0100, Daniel Kiper wrote:
> > On Wed, Mar 24, 2021 at 12:44:52PM +0800, Michael Chang via Grub-devel
> > wrote:
> > > On Tue, Mar 23, 2021 at 05:33:12PM +0100, Daniel Kiper wrote:
> > > > On Mon, Mar 22, 2021 at 08:45:27PM +0000, Colin Watson wrote:
[snip]
> > After some thinking it seems to me we can do this. I can take "i386-pc:
> > build verifiers API as module", "kern/misc: Move grub_printf_fmt_check
> > to gfxmenu" and similar patches into 2.06. I will revert after the
> > release all the patches which adds ifdefery or make code ugly and do not
> > benefit other platforms than i386-pc. This way you will have support for
> > small MBR gaps in 2.06 and I will have clean code after 2.06 release.
> >
> > Does it work for you guys?
>
> Does anybody care?
Could you please consider not reverting them ? For me it is worse than
keeping them as distribution specific patch, as we will have a hard time
to explain what's going on when we have to reintroduce them in rebasing
to commits later to 2.06.
Thanks,
Michael
>
> Daniel
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel