[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use
|
From: |
Daniel Kiper |
|
Subject: |
Re: [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper |
|
Date: |
Tue, 23 Mar 2021 20:35:23 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
Hi Adrian,
On Tue, Mar 23, 2021 at 08:16:43PM +0100, John Paul Adrian Glaubitz wrote:
> Hello!
>
> On 3/18/21 9:38 AM, John Paul Adrian Glaubitz wrote:
> > On 3/2/21 7:01 PM, Daniel Kiper wrote:
> >> From: Peter Jones <pjones@redhat.com>
> >>
> >> Add a init_pe_section() helper function to setup PE sections. This makes
> >> the code simpler and easier to read.
> >>
> >> Signed-off-by: Peter Jones <pjones@redhat.com>
> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> >> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> >
> > This change broke GRUB on ia64 for me. It now fails to perform any basic
> > commands:
>
> Any chance someone could have a look at this? As explained in the follow-up
> mails,
> the problem is that the pointer pointing to the modules location in the core
> image
> deviate from the actual modules location as the former was updated but the
> former
> not.
I chatted about that with Javier yesterday. He told me he will take
a look at the issue...
Daniel
- [SECURITY PATCH 090/117] disk/lvm: Do not overread metadata, (continued)
- [SECURITY PATCH 090/117] disk/lvm: Do not overread metadata, Daniel Kiper, 2021/03/02
- [SECURITY PATCH 095/117] kern/parser: Fix a memory leak, Daniel Kiper, 2021/03/02
- [SECURITY PATCH 092/117] disk/lvm: Do not allow a LV to be it's own segment's node's LV, Daniel Kiper, 2021/03/02
- [SECURITY PATCH 098/117] kern/parser: Refactor grub_parser_split_cmdline() cleanup, Daniel Kiper, 2021/03/02
- [SECURITY PATCH 102/117] util/mkimage: Remove unused code to add BSS section, Daniel Kiper, 2021/03/02
- [SECURITY PATCH 108/117] util/mkimage: Refactor section setup to use a helper, Daniel Kiper, 2021/03/02
[SECURITY PATCH 107/117] util/mkimage: Improve data_size value calculation, Daniel Kiper, 2021/03/02
[SECURITY PATCH 100/117] kern/parser: Fix a stack buffer overflow, Daniel Kiper, 2021/03/02
[SECURITY PATCH 103/117] util/mkimage: Use grub_host_to_target32() instead of grub_cpu_to_le32(), Daniel Kiper, 2021/03/02
[SECURITY PATCH 105/117] util/mkimage: Unify more of the PE32 and PE32+ header set-up, Daniel Kiper, 2021/03/02
[SECURITY PATCH 101/117] kern/efi: Add initial stack protector implementation, Daniel Kiper, 2021/03/02
[SECURITY PATCH 109/117] util/mkimage: Add an option to import SBAT metadata into a .sbat section, Daniel Kiper, 2021/03/02
[SECURITY PATCH 115/117] gfxmenu/gui: Check printf() format in the gui_progress_bar and gui_label, Daniel Kiper, 2021/03/02
[SECURITY PATCH 104/117] util/mkimage: Always use grub_host_to_target32() to initialize PE stack and heap stuff, Daniel Kiper, 2021/03/02
[SECURITY PATCH 112/117] kern/misc: Split parse_printf_args() into format parsing and va_list handling, Daniel Kiper, 2021/03/02