[PATCH 0/8] Various fixes/improvements for tests

[Glenn Washburn]

The first 4 patches in the series have already been submitted as part of the
GitLab CI patch series. I've included them here because they logically go with
the subsequent 4 patches and because I suspect that the GitLab CI patch series
is given lower priority than this one will be. So the first 4 patches here
where needed for the GitLab CI and thus have been tested as such.

Patch #1 is needed when runing on systems that do not have LANG set to something
UTF capable. We need UTF to successfully run some of the filesystem tests on
internationalization.

Patch #2 was required to get the arm-efi tests to be successful, but I wonder
if it can change depending on setup (eg. qemu version). Is anyone currently
running arm-efi tests successfully?

Patch #3 seems obviously the right way to do it. So that makes me question why
it wasn't done this way to begin with. Am I missing something? Was there a
reason not to do it this way (perhaps running these tests on OS/arches I'm not)?

Patch #4 was not strictly necessary for the GitLab CI, but it was valuable in
debugging test failures (we really only care about the failure code of
grub-shell).

Patches #5 and #6 decrease false positive test results, that is tests shown
as failing that are not actually failing (ie something prevented the test
from actually running).

Patch #7 marks tests as skipped when they are skipped, instead of marking them
with success as is currently done.

Patch #8 is trivial

Glenn

Glenn Washburn (8):
  tests: Make sure LANG is set properly for iso9660_test
  tests: Fix partmap_test for arm*-efi, disk numbering has changed
  tests: When checking squashfs fstime, use superblock last modified
    time
  tests: Fail immediately when grub-shell fails and do not occlude the
    error code
  tests: Make setup errors in grub-fs-tester hard errors
  tests: A failure of mktemp should cause the test script to exit with
    code 99
  tests: Exit with skipped exit code when test not performed
  tests: Use @BUILD_SHEBANG@ autoconf var instead of literal shell

 tests/ahci_test.in             | 18 +++++++++++-------
 tests/cdboot_test.in           | 11 ++++++-----
 tests/core_compress_test.in    |  8 +++++---
 tests/ehci_test.in             | 18 +++++++++++-------
 tests/f2fs_test.in             |  2 +-
 tests/fddboot_test.in          | 19 ++++++++++---------
 tests/gettext_strings_test.in  |  2 +-
 tests/grub_cmd_date.in         |  5 +++--
 tests/grub_cmd_set_date.in     |  6 +++---
 tests/grub_cmd_test.in         |  7 ++++---
 tests/grub_script_blockarg.in  |  4 ++--
 tests/grub_script_expansion.in |  3 ++-
 tests/gzcompress_test.in       |  3 ++-
 tests/hddboot_test.in          |  9 +++++----
 tests/iso9660_test.in          |  6 ++++++
 tests/lzocompress_test.in      |  3 ++-
 tests/netboot_test.in          | 15 ++++++++-------
 tests/ohci_test.in             | 18 +++++++++++-------
 tests/partmap_test.in          | 18 +++++++++---------
 tests/pata_test.in             | 13 +++++++------
 tests/pseries_test.in          |  2 +-
 tests/syslinux_test.in         |  2 +-
 tests/test_sha512sum.in        |  7 ++++---
 tests/uhci_test.in             | 18 +++++++++++-------
 tests/util/grub-fs-tester.in   | 17 ++++++++++++-----
 tests/xzcompress_test.in       |  3 ++-
 26 files changed, 140 insertions(+), 97 deletions(-)

-- 
2.27.0