Re: [PATCH v6 00/14] error: Do compile-time format string checking on grub>

[Daniel Kiper]

On Thu, Mar 04, 2021 at 06:22:31PM -0600, Glenn Washburn wrote:
> Daniel, you mentioned wanting a separate patch series which is the real fix
> for patch #12. I've added it to this patch series, since they go together.
> I can send the single patch as a separate thread if that still desirable.

For all Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

I will take all stuff up to #13. The #14 will be applied after 2.06 release.

Thank you for fixing these issues.

By the way, my I ask you once again to send each patch series as
separate thread. Now you are attaching all patch sets to one cover letter
which is confusing. Please stop doing that.

Daniel

> Changes since v5
>  * Fix formatting issues with spaces around format string macros and casts
>  * Add extra patch #14 which is the better fix for #12, but needs more testing
>
> Glenn
>
> Glenn Washburn (14):
>   misc: Format string for grub_error should be a literal
>   error: grub_error missing format string argument
>   error: grub_error format string add missing format code
>   dmraid_nvidia: Format string error in grub_error
>   grub_error: Use format code PRIuGRUB_SIZE for variables of type
>     grub_size_t
>   pgp: Format code for grub_error is incorrect
>   efi: Format string error in grub_error
>   error: Use PRI* macros to get correct format string code across
>     architectures
>   error: Use format code PRIxGRUB_UINT64_T for 64-bit uint argument in
>     grub_error
>   error: Use format code PRIxGRUB_UINT64_T for 64-bit arg in grub_error
>   error: Use format code PRIuGRUB_UINT64_T for 64-bit typed fileblock in
>     grub_error
>   error: Use format code llu for 64-bit uint bp->blk_prop in grub_error
>   error: Do compile-time format string checking on grub_error
>   zfs: Use grub_uint64_t instead of 1ULL in BF64_*CODE macros