[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 06/14] pgp: Format code for grub_error is incorrect
From: |
Glenn Washburn |
Subject: |
[PATCH v6 06/14] pgp: Format code for grub_error is incorrect |
Date: |
Thu, 4 Mar 2021 18:22:37 -0600 |
The format code is for a 32-bit int, but the argument, keyid, is declared as
a 64 bit int. The comment above says keyid is 32-bit. I'm not sure if the
comment or declaration is wrong, so force the display of a 64-bit int for
now.
Signed-off-by: Glenn Washburn <development@efficientek.com>
---
grub-core/commands/pgp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/grub-core/commands/pgp.c b/grub-core/commands/pgp.c
index bbf6871fe..5daa1e9d0 100644
--- a/grub-core/commands/pgp.c
+++ b/grub-core/commands/pgp.c
@@ -633,8 +633,8 @@ grub_verify_signature_real (struct grub_pubkey_context
*ctxt,
if (!sk)
{
/* TRANSLATORS: %08x is 32-bit key id. */
- grub_error (GRUB_ERR_BAD_SIGNATURE, N_("public key %08x not found"),
- keyid);
+ grub_error (GRUB_ERR_BAD_SIGNATURE,
+ N_("public key %08" PRIxGRUB_UINT64_T " not found"), keyid);
goto fail;
}
--
2.27.0
- [PATCH v6 00/14] error: Do compile-time format string checking on grub>, Glenn Washburn, 2021/03/04
- [PATCH v6 07/14] efi: Format string error in grub_error, Glenn Washburn, 2021/03/04
- [PATCH v6 02/14] error: grub_error missing format string argument, Glenn Washburn, 2021/03/04
- [PATCH v6 06/14] pgp: Format code for grub_error is incorrect,
Glenn Washburn <=
- [PATCH v6 10/14] error: Use format code PRIxGRUB_UINT64_T for 64-bit arg in grub_error, Glenn Washburn, 2021/03/04
- [PATCH v6 08/14] error: Use PRI* macros to get correct format string code across architectures, Glenn Washburn, 2021/03/04
- [PATCH v6 01/14] misc: Format string for grub_error should be a literal, Glenn Washburn, 2021/03/04
- [PATCH v6 03/14] error: grub_error format string add missing format code, Glenn Washburn, 2021/03/04
- [PATCH v6 05/14] grub_error: Use format code PRIuGRUB_SIZE for variables of type grub_size_t, Glenn Washburn, 2021/03/04
- [PATCH v6 09/14] error: Use format code PRIxGRUB_UINT64_T for 64-bit uint argument in grub_error, Glenn Washburn, 2021/03/04
- [PATCH v6 04/14] dmraid_nvidia: Format string error in grub_error, Glenn Washburn, 2021/03/04
- [PATCH v6 14/14] zfs: Use grub_uint64_t instead of 1ULL in BF64_*CODE macros, Glenn Washburn, 2021/03/04
- [PATCH v6 11/14] error: Use format code PRIuGRUB_UINT64_T for 64-bit typed fileblock in grub_error, Glenn Washburn, 2021/03/04
- [PATCH v6 13/14] error: Do compile-time format string checking on grub_error, Glenn Washburn, 2021/03/04